linux-kernel - Re: [PATCH v1 2/2] arm64: dts: qcom: sc7280: update bluetooth node in SC7280 IDP2 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03a5d78d834a8c0b1463004bc1e4b015@codeaurora.org>
Date:   Tue, 12 Oct 2021 15:31:46 +0530
From:   bgodavar@...eaurora.org
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     marcel@...tmann.org, bjorn.andersson@...aro.org,
        johan.hedberg@...il.com, linux-kernel@...r.kernel.org,
        linux-bluetooth@...r.kernel.org, hemantg@...eaurora.org,
        linux-arm-msm@...r.kernel.org, rjliao@...eaurora.org,
        pharish@...eaurora.org, abhishekpandit@...omium.org
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: sc7280: update bluetooth node in
 SC7280 IDP2 board

Hi Matthias,

On 2021-10-06 23:09, Matthias Kaehlcke wrote:
> On Wed, Oct 06, 2021 at 06:00:03PM +0530, Balakrishna Godavarthi wrote:
>> Subject: arm64: dts: qcom: sc7280: update bluetooth node in SC7280 
>> IDP2 board
> 
> Not super helpful, what does 'update' mean?
> 
> It might be easier to have a single patch for both IDP boards, since
> the Bluetooth node is added in the common sc7280-idp.dtsi board,
> rather than explaining what this patch does :)
[Bala]: Sure will have one patch.

> 
>> This patch updates bluetooth node in SC7280 IDP2 board.
>> 
>> Signed-off-by: Balakrishna Godavarthi <bgodavar@...eaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts 
>> b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
>> index 1fc2add..5c8d54b 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
>> @@ -15,9 +15,15 @@
>> 
>>  	aliases {
>>  		serial0 = &uart5;
>> +		bluetooth0 = &bluetooth;
>> +		hsuart0 = &uart7;
>>  	};
> 
> Sort aliases alphabetically
> 
>> 
>>  	chosen {
>>  		stdout-path = "serial0:115200n8";
>>  	};
>>  };
>> +
>> +&bluetooth: wcn6750-bt {
> 
> &bluetooth {
> 
>> +	vddio-supply = <&vreg_l18b_1p8>;
> 
> nit: if it's not really common across IDP boards or a default, you 
> could
> leave it unconfigured in sc7280-idp.dtsi, and set in both board files.
> Just an idea, with only two boards it doesn't really matter too much.

[Bala]: Sure will update in similar way.