linux-kernel - Re: [PATCH] Bluetooth: btrtl: Ask ic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DEFB4160-D88E-447C-8B19-DB9DBFC9869A@holtmann.org>
Date:   Tue, 12 Oct 2021 17:41:29 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Hilda Wu <hildawu@...ltek.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kai.heng.feng@...onical.com" <kai.heng.feng@...onical.com>,
        "apusaka@...omium.org" <apusaka@...omium.org>,
        Max Chou <max.chou@...ltek.com>,
        "alex_lu@...lsil.com.cn" <alex_lu@...lsil.com.cn>,
        KidmanLee <kidman@...ltek.com>
Subject: Re: [PATCH] Bluetooth: btrtl: Ask ic_info to drop firmware

Hi Hilda,

> I'm a little confused about this.
> Did you mean that if use existing MSFT/AOSP extensions vendor cmd/event to check device has this feature.
> This way is not meeting your conception, a simple way to tell which RTL device supports the MSFT or AOSP extensions?

issuing a HCI command and checking HCI command not supported error is not a good design. The Bluetooth Core spec doesn’t use that kind of design. It has supported features and supported commands. And so should any vendor extension.

Regards

Marcel