linux-kernel - Re: [PATCH 3/5] dyndbg: use alt-quotes in vpr-infos, not those user might use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWbUHOSZ8Sh0i5CO@kroah.com>
Date:   Wed, 13 Oct 2021 14:42:04 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jim Cromie <jim.cromie@...il.com>
Cc:     jbaron@...mai.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] dyndbg: use alt-quotes in vpr-infos, not those user
 might use

On Tue, Oct 12, 2021 at 12:33:08PM -0600, Jim Cromie wrote:
>    echo format $str +p > control
> 
> can be finicky from within a script, `awith respect to quoting

"`awith"?

> of input terms, so lets not complicate things by wrapping that input
> with either quoting char, using <%s> instead.
> 
> This draws a checkpatch warning on pr_cont() altered quoting.
> no functional changes.
> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
>  lib/dynamic_debug.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index e645807cb20a..75e702223730 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -132,7 +132,7 @@ static void vpr_info_dq(const struct ddebug_query *query, const char *msg)
>  			fmtlen--;
>  	}
>  
> -	v3pr_info("%s: func=\"%s\" file=\"%s\" module=\"%s\" format=\"%.*s\" lineno=%u-%u\n",
> +	v3pr_info("%s: func=<%s> file=<%s> module=<%s> format=<%.*s> lineno=%u-%u\n",

Wait, no, it now looks like you want '<' and '>' in the input lines
here.

That's confusing, why is this really all needed?

thanks,

greg k-h