linux-kernel - Re: [PATCH v3] x86/PCI: Ignore E820 reservations for bridge windows on newer systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWhJ2kmGzNMVY+cP@infradead.org>
Date:   Thu, 14 Oct 2021 08:16:42 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Myron Stowe <myron.stowe@...hat.com>,
        Juha-Pekka Heikkila <juhapekka.heikkila@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, linux-acpi@...r.kernel.org,
        linux-pci@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        Benoit Grégoire <benoitg@...us.ca>,
        Hui Wang <hui.wang@...onical.com>
Subject: Re: [PATCH v3] x86/PCI: Ignore E820 reservations for bridge windows
 on newer systems

On Thu, Oct 14, 2021 at 05:15:02PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 10/14/21 3:40 PM, Christoph Hellwig wrote:
> > On Thu, Oct 14, 2021 at 01:03:57PM +0200, Hans de Goede wrote:
> >> +	 * Some BIOS-es contain a bug where they add addresses which map to system
> >> +	 * RAM in the PCI bridge memory window returned by the ACPI _CRS method,
> > 
> > Please avoid the overly long lines in your comments.
> 
> ?
> 
> These lines are easily within the new 100 char line-length-limit ?

That is an exceptional limit if exceeding 80 improves readability for
individual lines.

> And checkpatch also does not complain about this.

checkpatch has been completely broken for a while and should not be
relied on in any way.