linux-kernel - Re: [PATCH v2 -next] blk-cgroup: synchoronize blkg creation against policy deactivation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Oct 2021 13:02:06 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     axboe@...nel.dk, paolo.valente@...aro.org, fchecconi@...il.com,
        avanzini.arianna@...il.com, mkoutny@...e.com,
        cgroups@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com
Subject: Re: [PATCH v2 -next] blk-cgroup: synchoronize blkg creation against
 policy deactivation

On Wed, Oct 13, 2021 at 08:44:56PM +0800, Yu Kuai wrote:
> @@ -1401,6 +1406,7 @@ void blkcg_deactivate_policy(struct request_queue *q,
>  	if (queue_is_mq(q))
>  		blk_mq_freeze_queue(q);
>  
> +	mutex_lock(&q->blkg_lock);
>  	spin_lock_irq(&q->queue_lock);

Given that deactivation drains q_usage_counter through
blk_mq_freeze_queue(), can't the blkg_conf_prep() just pin the usage count?

Thanks.

-- 
tejun