linux-kernel - Re: [PATCH] scsi: sd: print write through due to no caching mode page as warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fdaef0a-3370-3cf5-5564-99a1c59d2b6a@acm.org>
Date:   Wed, 13 Oct 2021 21:18:19 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     dgilbert@...erlog.com, jejb@...ux.ibm.com,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        martin.petersen@...cle.com
Subject: Re: [PATCH] scsi: sd: print write through due to no caching mode page
 as warning

On 10/13/21 00:50, Martin Kepplinger wrote:
> I only resending the same patch I sent in January before:
> https://lore.kernel.org/linux-scsi/20210122083000.32598-1-martin.kepplinger@puri.sm/

A common way to indicate this is to start the email subject with [PATCH 
RESEND].

> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index a646d27df681..33ea36b41136 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -2793,7 +2793,8 @@ sd_read_cache_type(struct scsi_disk *sdkp, unsigned char *buffer)
>   			}
>   		}
>   
> -		sd_first_printk(KERN_ERR, sdkp, "No Caching mode page found\n");
> +		sd_first_printk(KERN_WARNING, sdkp,
> +				"No Caching mode page found\n");
>   		goto defaults;
>   
>   	Page_found:
> @@ -2848,7 +2849,7 @@ sd_read_cache_type(struct scsi_disk *sdkp, unsigned char *buffer)
>   				"Assuming drive cache: write back\n");
>   		sdkp->WCE = 1;
>   	} else {
> -		sd_first_printk(KERN_ERR, sdkp,
> +		sd_first_printk(KERN_WARNING, sdkp,
>   				"Assuming drive cache: write through\n");
>   		sdkp->WCE = 0;
>   	}

Reviewed-by: Bart Van Assche <bvanassche@....org>