lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Oct 2021 23:21:05 -0500 From: Samuel Holland <samuel@...lland.org> To: Guo Ren <guoren@...nel.org>, Heiko Stübner <heiko@...ech.de> Cc: Anup Patel <anup@...infault.org>, Atish Patra <atish.patra@....com>, Marc Zyngier <maz@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Palmer Dabbelt <palmer@...belt.com>, "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>, linux-riscv <linux-riscv@...ts.infradead.org>, Guo Ren <guoren@...ux.alibaba.com>, Rob Herring <robh@...nel.org>, Palmer Dabbelt <palmerdabbelt@...gle.com> Subject: Re: [PATCH V3 1/2] dt-bindings: update riscv plic compatible string On 10/13/21 7:49 AM, Guo Ren wrote: >>>>>>>> - const: sifive,plic-1.0.0 >>>>>>> >>>>>>> The PLIC DT node requires two compatible string: >>>>>>> <implementation_compat>, <spec_compat> >>>>>>> >>>>>>> The C9xx PLIC is not RISC-V PLIC so, the DT node should >>>>>>> be: "thead,c900-plic", "thead,c9xx-plic" >>>>>>> >>>>>>> You need to change "- const: sifive,plic-1.0.0" to >>>>>>> - enum: >>>>>>> - sifive,plic-1.0.0 >>>>>>> - thead,c9xx-plic >> >> isn't XuanTie the series containing the c906 and c910? > XuanTie contain two CPU series: > riscv: c906, c910 > csky: c807, c810, c860 > >> So maybe >> thead,xuantie-plic >> for the spec compatible. >> >> So doing in full >> compatible = "thead,c906-plic", "thead,xuantie-plic" > How about: > compatible = "allwinner,d1-plic", "thead,c900-plic" To follow the <family>-<soc>-<device> pattern of existing Allwinner compatibles, the first string should be "allwinner,sun20i-d1-plic". Otherwise, this looks to me like the right thing to do. Regards, Samuel
Powered by blists - more mailing lists