linux-kernel - Re: [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Oct 2021 09:29:36 +0800
From:   Cai Huoqing <caihuoqing@...du.com>
To:     Arnd Bergmann <arnd@...nel.org>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        <linux-iio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe_unused

On 13 10月 21 16:43:26, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Without CONFIG_PM_SLEEP, the runtime suspend/resume functions
> are unused, producing a warning:
> 
> drivers/iio/adc/imx8qxp-adc.c:433:12: error: 'imx8qxp_adc_runtime_resume' defined but not used [-Werror=unused-function]
>   433 | static int imx8qxp_adc_runtime_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/iio/adc/imx8qxp-adc.c:419:12: error: 'imx8qxp_adc_runtime_suspend' defined but not used [-Werror=unused-function]
>   419 | static int imx8qxp_adc_runtime_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Mark them as __maybe_unused to shut up the compiler.
> 
> Fixes: 7bce634d02e6 ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Cai Huoqing <caihuoqing@...du.com>

> ---
>  drivers/iio/adc/imx8qxp-adc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
> index 5030e0d8318d..901dd8e1b32f 100644
> --- a/drivers/iio/adc/imx8qxp-adc.c
> +++ b/drivers/iio/adc/imx8qxp-adc.c
> @@ -416,7 +416,7 @@ static int imx8qxp_adc_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int imx8qxp_adc_runtime_suspend(struct device *dev)
> +static __maybe_unused int imx8qxp_adc_runtime_suspend(struct device *dev)
>  {
>  	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>  	struct imx8qxp_adc *adc = iio_priv(indio_dev);
> @@ -430,7 +430,7 @@ static int imx8qxp_adc_runtime_suspend(struct device *dev)
>  	return 0;
>  }
>  
> -static int imx8qxp_adc_runtime_resume(struct device *dev)
> +static __maybe_unused int imx8qxp_adc_runtime_resume(struct device *dev)
>  {
>  	struct iio_dev *indio_dev = dev_get_drvdata(dev);
>  	struct imx8qxp_adc *adc = iio_priv(indio_dev);
> -- 
> 2.29.2
>