[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50f71530-bab0-58f4-cf90-a7c1b60b9716@infradead.org>
Date: Wed, 13 Oct 2021 18:40:41 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Cai Huoqing <caihuoqing@...du.com>, Arnd Bergmann <arnd@...nel.org>
Cc: Jonathan Cameron <jic23@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Arnd Bergmann <arnd@...db.de>,
Lars-Peter Clausen <lars@...afoo.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
NXP Linux Team <linux-imx@....com>,
linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe_unused
On 10/13/21 6:29 PM, Cai Huoqing wrote:
> On 13 10月 21 16:43:26, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> Without CONFIG_PM_SLEEP, the runtime suspend/resume functions
>> are unused, producing a warning:
>>
>> drivers/iio/adc/imx8qxp-adc.c:433:12: error: 'imx8qxp_adc_runtime_resume' defined but not used [-Werror=unused-function]
>> 433 | static int imx8qxp_adc_runtime_resume(struct device *dev)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/iio/adc/imx8qxp-adc.c:419:12: error: 'imx8qxp_adc_runtime_suspend' defined but not used [-Werror=unused-function]
>> 419 | static int imx8qxp_adc_runtime_suspend(struct device *dev)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Mark them as __maybe_unused to shut up the compiler.
>>
>> Fixes: 7bce634d02e6 ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Reviewed-by: Cai Huoqing <caihuoqing@...du.com>
Looks the same as
https://lore.kernel.org/all/20211013014658.2798-1-caihuoqing@baidu.com/
but that one is mixing the Fixes: tag.
>> ---
>> drivers/iio/adc/imx8qxp-adc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
>> index 5030e0d8318d..901dd8e1b32f 100644
>> --- a/drivers/iio/adc/imx8qxp-adc.c
>> +++ b/drivers/iio/adc/imx8qxp-adc.c
>> @@ -416,7 +416,7 @@ static int imx8qxp_adc_remove(struct platform_device *pdev)
>> return 0;
>> }
>>
>> -static int imx8qxp_adc_runtime_suspend(struct device *dev)
>> +static __maybe_unused int imx8qxp_adc_runtime_suspend(struct device *dev)
>> {
>> struct iio_dev *indio_dev = dev_get_drvdata(dev);
>> struct imx8qxp_adc *adc = iio_priv(indio_dev);
>> @@ -430,7 +430,7 @@ static int imx8qxp_adc_runtime_suspend(struct device *dev)
>> return 0;
>> }
>>
>> -static int imx8qxp_adc_runtime_resume(struct device *dev)
>> +static __maybe_unused int imx8qxp_adc_runtime_resume(struct device *dev)
>> {
>> struct iio_dev *indio_dev = dev_get_drvdata(dev);
>> struct imx8qxp_adc *adc = iio_priv(indio_dev);
>> --
--
~Randy
Powered by blists - more mailing lists