linux-kernel - RE: [EXT] Re: [PATCH v10 03/13] media: amphion: add amphion vpu device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB63414D1465CDABB6E5550529E7B89@AM6PR04MB6341.eurprd04.prod.outlook.com>
Date:   Thu, 14 Oct 2021 01:49:49 +0000
From:   Ming Qian <ming.qian@....com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC:     "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [EXT] Re: [PATCH v10 03/13] media: amphion: add amphion vpu
 device driver

> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@...radead.org]
> Sent: Thursday, October 14, 2021 6:17 AM
> To: Ming Qian <ming.qian@....com>; mchehab@...nel.org;
> shawnguo@...nel.org; robh+dt@...nel.org; s.hauer@...gutronix.de
> Cc: hverkuil-cisco@...all.nl; kernel@...gutronix.de; festevam@...il.com;
> dl-linux-imx <linux-imx@....com>; Aisheng Dong <aisheng.dong@....com>;
> linux-media@...r.kernel.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Subject: [EXT] Re: [PATCH v10 03/13] media: amphion: add amphion vpu
> device driver
> 
> Caution: EXT Email
> 
> On 10/13/21 1:27 AM, Ming Qian wrote:
> > diff --git a/drivers/media/platform/Kconfig
> > b/drivers/media/platform/Kconfig index d9f90084c2f6..2465a5f7a073
> > 100644
> > --- a/drivers/media/platform/Kconfig
> > +++ b/drivers/media/platform/Kconfig
> > @@ -200,6 +200,25 @@ config VIDEO_TI_CAL_MC
> >
> >   endif # VIDEO_TI_CAL
> >
> > +config VIDEO_AMPHION_VPU
> > +     tristate "Amphion VPU(Video Processing Unit) Codec IP"
> > +     depends on ARCH_MXC
> > +     depends on MEDIA_SUPPORT
> > +     depends on VIDEO_DEV
> > +     depends on VIDEO_V4L2
> > +     select V4L2_MEM2MEM_DEV
> > +     select VIDEOBUF2_DMA_CONTIG
> > +     select VIDEOBUF2_VMALLOC
> > +     default y
> 
> This should not be "default y" unless it is needed to boot up some
> platform/machine. And even then it should depend on that platform/machine
> if possible.

I'll remove the " default y " and submit again

> 
> And there are 2 other drivers in that same Kconfig file that have the same
> problem.
> 
> > +     help
> > +       Amphion VPU Codec IP contains two parts: Windsor and Malone.
> > +       Windsor is encoder that supports H.264, and Malone is decoder
> > +       that supports H.264, HEVC, and other video formats.
> > +       This is a V4L2 driver for NXP MXC 8Q video accelerator hardware.
> > +       It accelerates encoding and decoding operations on
> > +       various NXP SoCs.
> > +       To compile this driver as a module choose m here.
> 
> 
> --
> ~Randy