linux-kernel - Re:Re: [PATCH v4 2/4] dt-bindings: mfd: sprd: Add bindings for ums512 global registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163417628586.936110.17321921086246870791@swboyd.mtv.corp.google.com>
Date:   Wed, 13 Oct 2021 18:51:25 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     ChunyanZhang <zhanglyra@....com>
Cc:     Chunyan Zhang <zhang.lyra@...il.com>,
        Rob Herring <robh+dt@...nel.org>, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, Baolin Wang <baolin.wang7@...il.com>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <chunyan.zhang@...soc.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re:Re: [PATCH v4 2/4] dt-bindings: mfd: sprd: Add bindings for ums512 global registers

Quoting ChunyanZhang (2021-10-13 16:49:40)
> At 2021-10-14 06:04:32, "Stephen Boyd" <sboyd@...nel.org> wrote:
> >Quoting Chunyan Zhang (2021-09-22 23:41:35)
> >> diff --git a/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml b/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml
> >> +
> >> +examples:
> >> +  - |
> >> +    ap_apb_regs: syscon@...00000 {
> >> +      compatible = "sprd,ums512-glbregs", "syscon", "simple-mfd";
> >> +      reg = <0x71000000 0x3000>;
> >> +      #address-cells = <1>;
> >> +      #size-cells = <1>;
> >> +      ranges = <0 0x71000000 0x3000>;
> >> +
> >> +      clock-controller@0 {
> >> +        compatible = "sprd,ums512-apahb-gate";
> >
> >Why is this a subnode of a syscon and simple-mfd? Why not put the>clock-controller@...00000 directly onto the bus? Does making it a child
> >node help somehow?
> 
> These clocks are at the same register range with global registers. I originally put them directly onto the bus indeed when submitting the patches for SC9863A clocks last year, and it had a private property named 'sprd,syscon' which could provide regmap for these clocks.
> 
> Rob suggested [1] us to make them a child of the syscon, and would not need the private property 'sprd, syscon' then.

Why do you need to use a syscon? Are the registers shared with some
other driver?

2019 was two years ago...