linux-kernel - RE: [PATCH] ACPI, APEI, EINJ: Relax platform response timeout to 1 second.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d492cef3640414d85ecfdb602ad6fa0@intel.com>
Date:   Fri, 15 Oct 2021 15:37:06 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Shuai Xue <xueshuai@...ux.alibaba.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "bp@...en8.de" <bp@...en8.de>,
        "james.morse@....com" <james.morse@....com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>
CC:     "zhangliguang@...ux.alibaba.com" <zhangliguang@...ux.alibaba.com>,
        "zhuo.song@...ux.alibaba.com" <zhuo.song@...ux.alibaba.com>
Subject: RE: [PATCH] ACPI, APEI, EINJ: Relax platform response timeout to 1
 second.

> We observe that the waiting time for DDR error injection is about 10 ms
> and that for PCIe error injection is about 500 ms in Arm platfrom.
>
> In this patch, we relax the response timeout to 1 second and allow user to
> pass the time out value as a argument.

Spinning for 1ms was maybe ok. Spinning for up to 1s seems like a bad idea.

This code is executed inside a mutex ... so maybe it is safe to sleep instead of spin?

-Tony