linux-kernel - Re: [PATCH] KVM: x86/mmu: kvm_faultin_pfn has to return false if pfh is returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9af711a-5ce0-3143-3f84-79026be30cef@redhat.com>
Date:   Fri, 15 Oct 2021 18:38:34 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Andrei Vagin <avagin@...il.com>, linux-kernel@...r.kernel.org,
        Sean Christopherson <seanjc@...gle.com>, kvm@...r.kernel.org
Cc:     Maxim Levitsky <mlevitsk@...hat.com>
Subject: Re: [PATCH] KVM: x86/mmu: kvm_faultin_pfn has to return false if pfh
 is returned

On 15/10/21 18:32, Andrei Vagin wrote:
> This looks like a typo in 8f32d5e563cb. This change didn't intend to do
> any functional changes.
> 
> The problem was caught by gVisor tests.
> 
> Fixes: 8f32d5e563cb ("KVM: x86/mmu: allow kvm_faultin_pfn to return page fault handling code")
> Cc: Maxim Levitsky <mlevitsk@...hat.com>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Signed-off-by: Andrei Vagin <avagin@...il.com>
> ---
>   arch/x86/kvm/mmu/mmu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index 1a64ba5b9437..5dce77b45476 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -3956,7 +3956,7 @@ static bool kvm_faultin_pfn(struct kvm_vcpu *vcpu, bool prefault, gfn_t gfn,
>   
>   	*pfn = __gfn_to_pfn_memslot(slot, gfn, false, NULL,
>   				    write, writable, hva);
> -
> +	return false;
>   out_retry:
>   	*r = RET_PF_RETRY;
>   	return true;
> 

Ouch! Queued, thanks.

Paolo