linux-kernel - Re: [PATCH v2] pci: call cond_resched() after pci bus config writing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Oct 2021 06:06:50 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     menglong8.dong@...il.com
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Menglong Dong <imagedong@...cent.com>
Subject: Re: [PATCH v2] pci: call cond_resched() after pci bus config writing

On Fri, Oct 15, 2021 at 10:40:25AM +0800, menglong8.dong@...il.com wrote:
> From: Menglong Dong <imagedong@...cent.com>
> 
> While the system is running in KVM, pci config writing for virtio devices
> may cost long time (about 1-2ms), as it causes VM-exit. During
> __pci_bus_assign_resources(), pci_setup_bridge(), which can write pci
> config up to 10 times, can be called many times without any
> cond_resched(). So __pci_bus_assign_resources() can cause 25+ms
> scheduling latency with !CONFIG_PREEMPT.
> 
> To solve this problem, call cond_resched() after pci config writing.

See https://lore.kernel.org/r/20211013190014.GA1909934@bhelgaas
for comments about subject line, s/pci/PCI/, line length, etc.

> Signed-off-by: Menglong Dong <imagedong@...cent.com>
> ---
> v2:
> - use cond_resched() instead of _cond_resched()
> ---
>  drivers/pci/access.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/access.c b/drivers/pci/access.c
> index 46935695cfb9..4c52a50f2c46 100644
> --- a/drivers/pci/access.c
> +++ b/drivers/pci/access.c
> @@ -57,6 +57,7 @@ int noinline pci_bus_write_config_##size \
>  	pci_lock_config(flags);						\
>  	res = bus->ops->write(bus, devfn, pos, len, value);		\
>  	pci_unlock_config(flags);					\
> +	cond_resched();						\
>  	return res;							\
>  }
>  
> -- 
> 2.27.0
>