linux-kernel - Re: [PATCH] media: dvb-frontends/stv0367: remove redundant variable ADCClk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Oct 2021 12:07:00 +0100
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Colin King <colin.king@...onical.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dvb-frontends/stv0367: remove redundant variable ADCClk_Hz

Quoting Colin King (2021-10-14 16:32:53)
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable ADCClk_Hz is being initialised with a variable that is never read
> and then re-assigned immediately afterwards. Clean up the code by removing
> it and just returning the return value from the call to stv0367cab_get_mclk
> 

Indeed LGTM.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/media/dvb-frontends/stv0367.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c
> index 6c2b05fae1c5..95e376f23506 100644
> --- a/drivers/media/dvb-frontends/stv0367.c
> +++ b/drivers/media/dvb-frontends/stv0367.c
> @@ -1797,11 +1797,7 @@ static u32 stv0367cab_get_mclk(struct dvb_frontend *fe, u32 ExtClk_Hz)
>  
>  static u32 stv0367cab_get_adc_freq(struct dvb_frontend *fe, u32 ExtClk_Hz)
>  {
> -       u32 ADCClk_Hz = ExtClk_Hz;
> -
> -       ADCClk_Hz = stv0367cab_get_mclk(fe, ExtClk_Hz);
> -
> -       return ADCClk_Hz;
> +       return stv0367cab_get_mclk(fe, ExtClk_Hz);
>  }
>  
>  static enum stv0367cab_mod stv0367cab_SetQamSize(struct stv0367_state *state,
> -- 
> 2.32.0
>