linux-kernel - Re: [PATCH] linux/container_of.h: switch to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mG2dX++A9S9+ycS-67rbkhFgF7B9wgEEpOoBKYpgPAkg@mail.gmail.com>
Date:   Fri, 15 Oct 2021 15:08:05 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] linux/container_of.h: switch to static_assert

On Fri, Oct 15, 2021 at 11:05 AM Rasmus Villemoes
<linux@...musvillemoes.dk> wrote:
>
> _Static_assert() is evaluated already in the compiler's frontend, and
> gives a somehat more to-the-point error, compared to the BUILD_BUG_ON
> macro, which only fires after the optimizer has had a chance to
> eliminate calls to functions marked with
> __attribute__((error)). In theory, this might make builds a tiny bit
> faster.

Thanks for this! Very much in favor!

Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

Perhaps Andrew may want to add a link to the related discussion
thread: https://lore.kernel.org/lkml/20211014132331.GA4811@kernel.org/T/

Cheers,
Miguel