linux-kernel - Re: [PATCH v2] staging: vt6655: Rename byPreambleType field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Oct 2021 15:47:46 +0100
From:   Karolina Drobnik <karolinadrobnik@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     outreachy-kernel@...glegroups.com, forest@...ttletooquiet.net,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vt6655: Rename byPreambleType field

Hi Greg,

On Fri, 2021-10-15 at 13:20 +0200, Greg KH wrote:
> Do not do multiple different things in the same commit and especially
> when you do not describe them in the changelog text.

I wasn't aware that changing this preamble-related variable would be
counted as a different thing. It makes sense, my bad.

Would you like me to amend the message to say that I also changed
`bb_get_frame_time` parameter or just drop this change completely?

Is there anything else I should address in my v3 patch?

Thanks,
Karolina