lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Oct 2021 18:01:18 -0600 From: Keith Busch <kbusch@...nel.org> To: Luis Chamberlain <mcgrof@...nel.org> Cc: axboe@...nel.dk, geoff@...radead.org, mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org, jim@...n.com, minchan@...nel.org, ngupta@...are.org, senozhatsky@...omium.org, richard@....at, miquel.raynal@...tlin.com, vigneshr@...com, dan.j.williams@...el.com, vishal.l.verma@...el.com, dave.jiang@...el.com, ira.weiny@...el.com, hch@....de, sagi@...mberg.me, linux-block@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-mtd@...ts.infradead.org, nvdimm@...ts.linux.dev, linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 02/13] nvme-multipath: add error handling support for add_disk() On Fri, Oct 15, 2021 at 04:52:08PM -0700, Luis Chamberlain wrote: > We never checked for errors on add_disk() as this function > returned void. Now that this is fixed, use the shiny new > error handling. > > Since we now can tell for sure when a disk was added, move > setting the bit NVME_NSHEAD_DISK_LIVE only when we did > add the disk successfully. > > Nothing to do here as the cleanup is done elsewhere. We take > care and use test_and_set_bit() because it is protects against > two nvme paths simultaneously calling device_add_disk() on the > same namespace head. Looks good, thank you. Reviewed-by: Keith Busch <kbusch@...nel.org>
Powered by blists - more mailing lists