lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 15 Oct 2021 17:13:48 -0700
From:   Dan Williams <>
To:     Luis Chamberlain <>
Cc:     Jens Axboe <>, Geoff Levand <>,
        Michael Ellerman <>,
        Benjamin Herrenschmidt <>,
        Paul Mackerras <>, Jim Paris <>,
        Minchan Kim <>,
        Nitin Gupta <>,,
        Richard Weinberger <>,,, Vishal L Verma <>,
        Dave Jiang <>,
        "Weiny, Ira" <>,
        Keith Busch <>,
        Christoph Hellwig <>,
        Sagi Grimberg <>,,
        linuxppc-dev <>,,
        Linux NVDIMM <>,,
        Linux Kernel Mailing List <>
Subject: Re: [PATCH 06/13] nvdimm/blk: avoid calling del_gendisk() on early failures

On Fri, Oct 15, 2021 at 4:53 PM Luis Chamberlain <> wrote:
> If nd_integrity_init() fails we'd get del_gendisk() called,
> but that's not correct as we should only call that if we're
> done with device_add_disk(). Fix this by providing unwinding
> prior to the devm call being registered and moving the devm
> registration to the very end.
> This should fix calling del_gendisk() if nd_integrity_init()
> fails. I only spotted this issue through code inspection. It
> does not fix any real world bug.

Just fyi, I'm preparing patches to delete this driver completely as it
is unused by any shipping platform. I hope to get that removal into

Powered by blists - more mailing lists