lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Oct 2021 12:27:34 +0530 From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> To: gregkh@...uxfoundation.org Cc: hemantk@...eaurora.org, bbhatt@...eaurora.org, loic.poulain@...aro.org, wangqing@...o.com, mhi@...ts.linux.dev, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, Manivannan Sadhasivam <mani@...nel.org>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Subject: [PATCH 3/3] bus: mhi: replace snprintf in show functions with sysfs_emit From: Qing Wang <wangqing@...o.com> coccicheck complains about the use of snprintf() in sysfs show functions. Fix the following coccicheck warning: drivers/bus/mhi/core/init.c:97:8-16: WARNING: use scnprintf or sprintf. Use sysfs_emit instead of scnprintf or sprintf makes more sense. Signed-off-by: Qing Wang <wangqing@...o.com> Reviewed-by: Hemant Kumar <hemantk@...eaurora.org> Reviewed-by: Manivannan Sadhasivam <mani@...nel.org> Link: https://lore.kernel.org/r/1634095550-3978-1-git-send-email-wangqing@vivo.com Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> --- drivers/bus/mhi/core/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c index 5aaca6d0f52b..a5a5c722731e 100644 --- a/drivers/bus/mhi/core/init.c +++ b/drivers/bus/mhi/core/init.c @@ -94,7 +94,7 @@ static ssize_t serial_number_show(struct device *dev, struct mhi_device *mhi_dev = to_mhi_device(dev); struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl; - return snprintf(buf, PAGE_SIZE, "Serial Number: %u\n", + return sysfs_emit(buf, "Serial Number: %u\n", mhi_cntrl->serial_number); } static DEVICE_ATTR_RO(serial_number); -- 2.25.1
Powered by blists - more mailing lists