linux-kernel - Re: [RFC PATCH] staging: r8188eu: Use completions instead of semaphores

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 16 Oct 2021 08:59:27 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Phillip Potter <phil@...lpotter.co.uk>
Cc:     Larry.Finger@...inger.net, gregkh@...uxfoundation.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        dan.carpenter@...cle.com
Subject: Re: [RFC PATCH] staging: r8188eu: Use completions instead of semaphores

On Friday, October 15, 2021 7:52:07 PM CEST Phillip Potter wrote:
> 
> Dear Fabio,
> 
> Sounds like a good approach to me, nice work.

Dear Phil,

Thanks for the "good job". These words always sound very rewarding :)

Please read my reply to Dan's message. I have decided to go through a 
different approach and make two patches for the semaphores => condition 
variables and a third for removing a duplicate 'if' statement in that  
rtw_cmd_thread() where now we have the semaphores.

As I wrote in that reply, I hope that you and Dan agree with me on this 
different approach to fix rtw_cmd_thread().

Thanks,

Fabio 

> I agree with Dan's
> feedback also - will wait for the final patchset then give it a test for
> you :-) Apologies I've been a little on the quiet side as of late.

P.S.: No need to apologize at all :)

I had noticed that you haven't been around for a while. I would have 
appreciated a review from you (and Larry) on the series of 32 patches that 
Pavel Skripkin and I co-developed and submitted some weeks ago.

However, I am 100% sure that you really had some important reasons for not 
being here.

> 
> Regards,
> Phil
>