lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Oct 2021 13:53:13 +0200 From: Michael Straube <straube.linux@...il.com> To: Martin Kaiser <martin@...ser.cx>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Larry Finger <Larry.Finger@...inger.net>, Phillip Potter <phil@...lpotter.co.uk>, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH 5/8] staging: r8188eu: PHY_SetRFPathSwitch_8188E is not used On 10/16/21 13:30, Martin Kaiser wrote: > Remove the PHY_SetRFPathSwitch_8188E function which is not used. > > It was the only caller of phy_setrfpathswitch_8188e, that function > can be removed as well. > > Signed-off-by: Martin Kaiser <martin@...ser.cx> > --- > drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 38 ------------------- > .../staging/r8188eu/include/Hal8188EPhyCfg.h | 3 -- > 2 files changed, 41 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c > index f01ee3cd8795..79f407c280be 100644 > --- a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c > +++ b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c > @@ -1189,41 +1189,3 @@ void PHY_LCCalibrate_8188E(struct adapter *adapt) > phy_LCCalibrate_8188E(adapt, false); > } > } > - > -static void phy_setrfpathswitch_8188e(struct adapter *adapt, bool main, bool is2t) > -{ > - struct hal_data_8188e *pHalData = GET_HAL_DATA(adapt); > - struct odm_dm_struct *dm_odm = &pHalData->odmpriv; > - > - if (!adapt->hw_init_completed) { > - u8 u1btmp; > - u1btmp = ODM_Read1Byte(dm_odm, REG_LEDCFG2) | BIT(7); > - ODM_Write1Byte(dm_odm, REG_LEDCFG2, u1btmp); > - ODM_SetBBReg(dm_odm, rFPGA0_XAB_RFParameter, BIT(13), 0x01); > - } > - > - if (is2t) { /* 92C */ > - if (main) > - ODM_SetBBReg(dm_odm, rFPGA0_XB_RFInterfaceOE, BIT(5) | BIT(6), 0x1); /* 92C_Path_A */ > - else > - ODM_SetBBReg(dm_odm, rFPGA0_XB_RFInterfaceOE, BIT(5) | BIT(6), 0x2); /* BT */ > - } else { /* 88C */ > - if (main) > - ODM_SetBBReg(dm_odm, rFPGA0_XA_RFInterfaceOE, BIT(8) | BIT(9), 0x2); /* Main */ > - else > - ODM_SetBBReg(dm_odm, rFPGA0_XA_RFInterfaceOE, BIT(8) | BIT(9), 0x1); /* Aux */ > - } > -} > - > -void PHY_SetRFPathSwitch_8188E(struct adapter *adapt, bool main) > -{ > - struct hal_data_8188e *pHalData = GET_HAL_DATA(adapt); > - struct odm_dm_struct *dm_odm = &pHalData->odmpriv; > - > - if (dm_odm->RFType == ODM_2T2R) { > - phy_setrfpathswitch_8188e(adapt, main, true); > - } else { > - /* For 88C 1T1R */ > - phy_setrfpathswitch_8188e(adapt, main, false); > - } > -} > diff --git a/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h b/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h > index 084bccc5dcb9..feae0b32cac6 100644 > --- a/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h > +++ b/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h > @@ -195,9 +195,6 @@ void PHY_SetBWMode8188E(struct adapter *adapter, > /* channel switch related funciton */ > void PHY_SwChnl8188E(struct adapter *adapter, u8 channel); > > -/* BB/MAC/RF other monitor API */ > -void PHY_SetRFPathSwitch_8188E(struct adapter *adapter, bool main); > - > void storePwrIndexDiffRateOffset(struct adapter *adapter, u32 regaddr, > u32 mask, u32 data); > /*--------------------------Exported Function prototype---------------------*/ > Acked-by: Michael Straube <straube.linux@...il.com>
Powered by blists - more mailing lists