linux-kernel - Re: [PATCH v2] staging: vc04_services: replace msleep() by usleep_range()

Open Source and information security mailing list archives

Date:   Sun, 17 Oct 2021 14:47:00 +0200
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Kushal-kothari <kushalkothari285@...il.com>,
        linux-arm-kernel@...ts.infradead.org, mike.rapoport@...il.com,
        kushalkothari2850@...il.com, outreachy-kernel@...glegroups.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, nsaenz@...nel.org,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v2] staging: vc04_services: replace msleep() by
 usleep_range()

Am 17.10.21 um 14:33 schrieb Julia Lawall:
>
> On Sun, 17 Oct 2021, Stefan Wahren wrote:
>
>> Hi,
>>
>> Am 17.10.21 um 11:29 schrieb Kushal-kothari:
>>> Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing
>>> msleep(unsigned long msecs) by usleep_range(unsigned long min, unsigned long max)
>>> in usecs as msleep(1ms~20ms) can sleep for upto 20 ms.
>>>
>>> Signed-off-by: Kushal-kothari <kushalkothari285@...il.com>
>>> ---
>>>
>>> Changes from v1: Reword both the subject and the log message.
>>>
>>>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>>> index 6fbafdfe340f..80a7898c5331 100644
>>> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>>> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>>> @@ -857,7 +857,7 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size,
>>>  		if (status != VCHIQ_RETRY)
>>>  			break;
>>>
>>> -		msleep(1);
>>> +		usleep_range(1000, 2000);
>> there was a recent discussion about this checkpatch warning [1]
> Should there be a comment about it?

Of course

Best regards

>
> julia
>
>> Best regards
>>
>> [1]
>> https://lore.kernel.org/linux-staging/260b38b8-6f3f-f6cc-0388-09a269ead507@i2se.com/
>>
>>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives