linux-kernel - Re: [PATCH v2] staging: vc04_services: replace msleep() by usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211103104854.GO2794@kadam>
Date:   Wed, 3 Nov 2021 13:48:54 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Stefan Wahren <stefan.wahren@...e.com>,
        Kushal-kothari <kushalkothari285@...il.com>,
        linux-arm-kernel@...ts.infradead.org, mike.rapoport@...il.com,
        kushalkothari2850@...il.com, outreachy-kernel@...glegroups.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, nsaenz@...nel.org,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v2] staging: vc04_services: replace msleep() by
 usleep_range()

On Sun, Oct 17, 2021 at 02:33:57PM +0200, Julia Lawall wrote:
> 
> 
> On Sun, 17 Oct 2021, Stefan Wahren wrote:
> 
> > Hi,
> >
> > Am 17.10.21 um 11:29 schrieb Kushal-kothari:
> > > Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing
> > > msleep(unsigned long msecs) by usleep_range(unsigned long min, unsigned long max)
> > > in usecs as msleep(1ms~20ms) can sleep for upto 20 ms.
> > >
> > > Signed-off-by: Kushal-kothari <kushalkothari285@...il.com>
> > > ---
> > >
> > > Changes from v1: Reword both the subject and the log message.
> > >
> > >  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > > index 6fbafdfe340f..80a7898c5331 100644
> > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > > @@ -857,7 +857,7 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size,
> > >  		if (status != VCHIQ_RETRY)
> > >  			break;
> > >
> > > -		msleep(1);
> > > +		usleep_range(1000, 2000);
> >
> > there was a recent discussion about this checkpatch warning [1]
> 
> Should there be a comment about it?

Even better would be an alternate wrapper around usleep(1) which would
silence the checkpatch warning.  Something like:

#define short_sleep() usleep(1)

regards,
dan carpenter