| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <yq15ytwfjkp.fsf@ca-mkp.ca.oracle.com>
Date: Sat, 16 Oct 2021 22:53:47 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: axboe@...nel.dk, jejb@...ux.ibm.com, martin.petersen@...cle.com,
agk@...hat.com, snitzer@...hat.com, colyli@...e.de,
kent.overstreet@...il.com, boris.ostrovsky@...cle.com,
jgross@...e.com, sstabellini@...nel.org, roger.pau@...rix.com,
geert@...ux-m68k.org, ulf.hansson@...aro.org, tj@...nel.org,
hare@...e.de, jdike@...toit.com, richard@....at,
anton.ivanov@...bridgegreys.com, johannes.berg@...el.com,
krisman@...labora.com, chris.obbard@...labora.com,
thehajime@...il.com, zhuyifei1999@...il.com, haris.iqbal@...os.com,
jinpu.wang@...os.com, miquel.raynal@...tlin.com, vigneshr@...com,
linux-mtd@...ts.infradead.org, linux-scsi@...r.kernel.org,
dm-devel@...hat.com, linux-bcache@...r.kernel.org,
xen-devel@...ts.xenproject.org, linux-m68k@...ts.linux-m68k.org,
linux-um@...ts.infradead.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 2/9] scsi/sr: add error handling support for add_disk()
Luis,
> We never checked for errors on add_disk() as this function returned
> void. Now that this is fixed, use the shiny new error handling.
>
> Just put the cdrom kref and have the unwinding be done by
> sr_kref_release().
Acked-by: Martin K. Petersen <martin.petersen@...cle.com>
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists