linux-kernel - Re: [PATCH 1/9] scsi/sd: add error handling support for add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YW3ZuQv1qpIXkd5b@bombadil.infradead.org>
Date:   Mon, 18 Oct 2021 13:31:53 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>, axboe@...nel.dk
Cc:     jejb@...ux.ibm.com, agk@...hat.com, snitzer@...hat.com,
        colyli@...e.de, kent.overstreet@...il.com,
        boris.ostrovsky@...cle.com, jgross@...e.com,
        sstabellini@...nel.org, roger.pau@...rix.com, geert@...ux-m68k.org,
        ulf.hansson@...aro.org, tj@...nel.org, hare@...e.de,
        jdike@...toit.com, richard@....at, anton.ivanov@...bridgegreys.com,
        johannes.berg@...el.com, krisman@...labora.com,
        chris.obbard@...labora.com, thehajime@...il.com,
        zhuyifei1999@...il.com, haris.iqbal@...os.com,
        jinpu.wang@...os.com, miquel.raynal@...tlin.com, vigneshr@...com,
        linux-mtd@...ts.infradead.org, linux-scsi@...r.kernel.org,
        dm-devel@...hat.com, linux-bcache@...r.kernel.org,
        xen-devel@...ts.xenproject.org, linux-m68k@...ts.linux-m68k.org,
        linux-um@...ts.infradead.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 1/9] scsi/sd: add error handling support for add_disk()

On Sat, Oct 16, 2021 at 10:51:48PM -0400, Martin K. Petersen wrote:
> 
> Luis,
> 
> > We never checked for errors on add_disk() as this function returned
> > void. Now that this is fixed, use the shiny new error handling.
> >
> > As with the error handling for device_add() we follow the same logic
> > and just put the device so that cleanup is done via the
> > scsi_disk_release().
> 
> Acked-by: Martin K. Petersen <martin.petersen@...cle.com>

Thanks, would you like Jens to pick this up and the other scsi/sr patch
or are you taking it through your tree?

  Luis