lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Oct 2021 23:45:57 +0200 From: Heiko Stuebner <heiko@...ech.de> To: Johan Jonker <jbx6244@...il.com>, kishon@...com, vkoul@...nel.org Cc: robh+dt@...nel.org, linux-phy@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188 Hi Vinod, Kishon, Am Samstag, 28. August 2021, 13:12:17 CEST schrieb Johan Jonker: > With the conversion of rockchip-usb-phy.yaml a long time used fallback > string for rk3066a/rk3188 was added. The linux driver doesn't do much with > the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c > does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example > don't match. Remove the usb-phy fallback string for rk3066a/rk3188 > to prevent possible strange side effects. > > Signed-off-by: Johan Jonker <jbx6244@...il.com> are you picking up this patch or can I get an Ack to just apply it together with the dts patch2? Thanks Heiko > --- > .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml > index f0fc8275d..499d55131 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml > @@ -11,13 +11,10 @@ maintainers: > > properties: > compatible: > - oneOf: > - - const: rockchip,rk3288-usb-phy > - - items: > - - enum: > - - rockchip,rk3066a-usb-phy > - - rockchip,rk3188-usb-phy > - - const: rockchip,rk3288-usb-phy > + enum: > + - rockchip,rk3066a-usb-phy > + - rockchip,rk3188-usb-phy > + - rockchip,rk3288-usb-phy > > "#address-cells": > const: 1 >
Powered by blists - more mailing lists