linux-kernel - Re: [PATCH 0/3] ucounts: misc fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOUHufafm96SU8UCxFgU_1y9KrxMxCeX=OZAceeZ0gH7mMRdvQ@mail.gmail.com>
Date:   Mon, 18 Oct 2021 16:28:56 -0600
From:   Yu Zhao <yuzhao@...gle.com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Alexey Gladkov <legion@...nel.org>,
        Rune Kleveland <rune.kleveland@...omedia.dk>,
        Jordan Glover <Golden_Miller83@...tonmail.ch>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>,
        "containers\\@lists.linux-foundation.org" 
        <containers@...ts.linux-foundation.org>,
        Hillf Danton <hdanton@...a.com>,
        David Howells <dhowells@...hat.com>,
        Jarkko Sakkinen <jarkko@...nel.org>
Subject: Re: [PATCH 0/3] ucounts: misc fixes

On Mon, Oct 18, 2021 at 11:21 AM Eric W. Biederman
<ebiederm@...ssion.com> wrote:
>
>
> While digging into the previous ucount kernel crashes I found some minor
> bugs in the ucount code.  When hit these bugs all result in a ucount
> either being counted in the wrong location or leak of a struct ucounts.
>
> Nothing particularly serious but certainly things that should be fixed.
>
> Eric W. Biederman (3):
>       ucounts: Pair inc_rlimit_ucounts with dec_rlimit_ucoutns in commit_creds
>       ucounts: Proper error handling in set_cred_ucounts
>       ucounts: Move get_ucounts from cred_alloc_blank to key_change_session_keyring
>
>  kernel/cred.c                | 9 ++++-----
>  security/keys/process_keys.c | 8 ++++++++
>  2 files changed, 12 insertions(+), 5 deletions(-)

Thanks for the fixes. Tested the whole series on the latest 5.15-rc6.

Tested-by: Yu Zhao <yuzhao@...gle.com>