linux-kernel - Re: [PATCH 0/4] ucounts: misc cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOUHufbWriGhH-CVZYF-WSH6H7Y7QvFen1_bOG_dQ15ozXhoFQ@mail.gmail.com>
Date:   Mon, 18 Oct 2021 16:29:18 -0600
From:   Yu Zhao <yuzhao@...gle.com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Alexey Gladkov <legion@...nel.org>,
        Rune Kleveland <rune.kleveland@...omedia.dk>,
        Jordan Glover <Golden_Miller83@...tonmail.ch>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>,
        "containers\\@lists.linux-foundation.org" 
        <containers@...ts.linux-foundation.org>,
        Hillf Danton <hdanton@...a.com>
Subject: Re: [PATCH 0/4] ucounts: misc cleanups

On Mon, Oct 18, 2021 at 11:55 AM Eric W. Biederman
<ebiederm@...ssion.com> wrote:
>
>
> The following changes are a set of miscellaneous fixes that makes
> the ucount code a little bit easier to read.  There are all things
> that I ran into while helping hunt the crazy reference count
> bug.
>
> I am aiming these at the next merge window and 5.16 rather than bug
> fixes to get into the current 5.15.
>
> Eric W. Biederman (4):
>       ucounts: In set_cred_ucounts assume new->ucounts is non-NULL
>       ucounts: Remove unnecessary test for NULL ucount in get_ucounts
>       ucounts: Add get_ucounts_or_wrap for clarity
>       ucounts: Use atomic_long_sub_return for clarity
>
>  kernel/cred.c   |  5 ++---
>  kernel/ucount.c | 20 +++++++++++++-------
>  2 files changed, 15 insertions(+), 10 deletions(-)

Thanks for the cleanups. Tested the whole series on the latest 5.15-rc6.

Tested-by: Yu Zhao <yuzhao@...gle.com>