linux-kernel - RE: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d136802937c24fca9e4823ace692a57a@realtek.com>
Date:   Mon, 18 Oct 2021 01:30:56 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     Colin King <colin.king@...onical.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf


> -----Original Message-----
> From: Colin King <colin.king@...onical.com>
> Sent: Friday, October 15, 2021 11:21 PM
> To: Kalle Valo <kvalo@...eaurora.org>; David S . Miller <davem@...emloft.net>; Jakub Kicinski
> <kuba@...nel.org>; Pkshih <pkshih@...ltek.com>; linux-wireless@...r.kernel.org;
> netdev@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH][next] rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The function rtw89_mac_enable_bb_rf is a void return type, so there is
> no return error code to ret, so the following check for an error in ret
> is redundant dead code and can be removed.
> 
> Addresses-Coverity: ("Logically dead code")
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/mac.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c
> b/drivers/net/wireless/realtek/rtw89/mac.c
> index 0171a5a7b1de..69384c43c046 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -2656,8 +2656,6 @@ int rtw89_mac_init(struct rtw89_dev *rtwdev)
>  		goto fail;
> 
>  	rtw89_mac_enable_bb_rf(rtwdev);
> -	if (ret)
> -		goto fail;
> 
>  	ret = rtw89_mac_sys_init(rtwdev);
>  	if (ret)
> --
> 2.32.0
> 
> ------Please consider the environment before printing this e-mail.