linux-kernel - Re: [PATCH V3 06/49] compiler_types.h: Add __noinstr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d2f0a4f-80e0-36c1-9421-d2c1af282a12@linux.alibaba.com>
Date:   Mon, 18 Oct 2021 17:16:46 +0800
From:   Lai Jiangshan <laijs@...ux.alibaba.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Lai Jiangshan <jiangshanlai@...il.com>,
        Miguel Ojeda <ojeda@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        Kees Cook <keescook@...omium.org>,
        Nathan Chancellor <nathan@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Marco Elver <elver@...gle.com>, Arnd Bergmann <arnd@...db.de>,
        Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH V3 06/49] compiler_types.h: Add __noinstr_section() for
 noinstr



On 2021/10/15 02:35, Miguel Ojeda wrote:
> On Thu, Oct 14, 2021 at 8:29 PM Nick Desaulniers
> <ndesaulniers@...gle.com> wrote:
>>
>> Can we use __section(section) here (from
>> include/linux/compiler_attributes.h)? I kind of can't stand seeing
>> attributes open coded.
> 
> Yes please! (though it can be an independent patch)
> 

I will use __section(section) in the updated patch.

I don't know whether it is worth for a new version for a relatively large patchset
with almost 50 patches since the feedback becomes less or I should wait for more
reviews from the x86 maintainers.  Especially the second half of the patchset which
is all about IST exceptions has no feedback since V2.

Thanks.
Lai