linux-kernel - Re: [PATCH v8 03/21] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nGPzDEeiQccTQ6QCeionfkfp01EDjp4btBfYKabXzGrg@mail.gmail.com>
Date:   Tue, 19 Oct 2021 23:09:19 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Robin van der Gracht <robin@...tonic.nl>,
        Rob Herring <robh+dt@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Machek <pavel@....cz>, Marek Behun <marek.behun@....cz>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, linux-leds@...r.kernel.org,
        linux-mips@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 03/21] auxdisplay: img-ascii-lcd: Fix lock-up when
 displaying empty string

On Tue, Oct 19, 2021 at 10:50 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> Unrelated to this patch (and no need to change it), but we could
> remove the conditional guarding the devm_kfree below to match this
> one.

Yeah, you did it when moving the code later on -- I guess we could
have done it before too, to match, like the sysfs_emit change does it
before, but it is not that important.

Cheers,
Miguel