linux-kernel - Re: [PATCH v8 03/21] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWBhBs3dpLFHo8VmUr22DkbXpPqMSwqkCVzpYYNA-5g4A@mail.gmail.com>
Date:   Wed, 20 Oct 2021 10:27:36 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Robin van der Gracht <robin@...tonic.nl>,
        Rob Herring <robh+dt@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Machek <pavel@....cz>, Marek Behun <marek.behun@....cz>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-leds <linux-leds@...r.kernel.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 03/21] auxdisplay: img-ascii-lcd: Fix lock-up when
 displaying empty string

Hi Miguel,

On Tue, Oct 19, 2021 at 11:09 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
> On Tue, Oct 19, 2021 at 10:50 PM Miguel Ojeda
> <miguel.ojeda.sandonis@...il.com> wrote:
> >
> > Unrelated to this patch (and no need to change it), but we could
> > remove the conditional guarding the devm_kfree below to match this
> > one.
>
> Yeah, you did it when moving the code later on -- I guess we could
> have done it before too, to match, like the sysfs_emit change does it
> before, but it is not that important.

As this patch fixes a DoS that can be triggered from userspace,
I wanted it to be a fix as small and concise as possible.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds