linux-kernel - Re: [PATCH] media: tw5864: Simplify 'tw5864

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163463974453.1853916.7698473612617245785@Monstersaurus>
Date:   Tue, 19 Oct 2021 11:35:44 +0100
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        andrey.utkin@...p.bluecherry.net, anton@...p.bluecherry.net,
        maintainers@...echerrydvr.com, mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] media: tw5864: Simplify 'tw5864_finidev()'

Quoting Christophe JAILLET (2021-10-16 09:40:29)
> Some resources are allocated with 'pci_request_regions()', so use
> 'pci_release_regions()' to free them, instead of a verbose
> 'release_mem_region()'.

And the driver was even already using pci_release_regions() in
tw5864_initdev(), so indeed this makes it more consistent too.

I'm curious that tw5864_initdev() calls pci_enable_device() (and
pci_disable_device in it's error path), while tw5864_finidev() doesn't.

Would you like to submit a patch to fix that on top of this one? or should I?

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> There is no point in calling 'devm_kfree()'. The corresponding resource is
> managed, so it will be fried automatically.

Indeed.

> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/media/pci/tw5864/tw5864-core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/pci/tw5864/tw5864-core.c b/drivers/media/pci/tw5864/tw5864-core.c
> index 23d3cae54a5d..fee3b7711901 100644
> --- a/drivers/media/pci/tw5864/tw5864-core.c
> +++ b/drivers/media/pci/tw5864/tw5864-core.c
> @@ -333,11 +333,9 @@ static void tw5864_finidev(struct pci_dev *pci_dev)
>  
>         /* release resources */
>         iounmap(dev->mmio);
> -       release_mem_region(pci_resource_start(pci_dev, 0),
> -                          pci_resource_len(pci_dev, 0));
> +       pci_release_regions(pci_dev);
>  
>         v4l2_device_unregister(&dev->v4l2_dev);
> -       devm_kfree(&pci_dev->dev, dev);
>  }
>  
>  static struct pci_driver tw5864_pci_driver = {
> -- 
> 2.30.2
>