linux-kernel - Re: [PATCH] thermal: imx: Fix temperature measurements on i.MX6 after alarm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Oct 2021 12:35:25 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Petr Benes <petrben@...il.com>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Michal Vokáč <michal.vokac@...ft.com>,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
        linux-pm@...r.kernel.org, Shawn Guo <shawnguo@...nel.org>,
        Amit Kucheria <amitk@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Petr Beneš <petr.benes@...ft.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH] thermal: imx: Fix temperature measurements on i.MX6
 after alarm

Hi Petr,

On Tue, Oct 19, 2021 at 09:24:44AM +0200, Petr Benes wrote:
> On Mon, 18 Oct 2021 at 13:38, Daniel Lezcano <daniel.lezcano@...aro.org> wrote:
> >
> > On 18/10/2021 13:28, Oleksij Rempel wrote:
> > > Hi Michal,
> > >
> > > I hope you have seen this patch:
> > > https://lore.kernel.org/all/20210924115032.29684-1-o.rempel@pengutronix.de/
> > >
> > > Are there any reason why this was ignored?
> >
> > No reasons, I was waiting for some tags before merging it. But I forget
> > about it when reviewing the current patch.
> 
> Tested Oleksij's patch. It works OK. A question arose. Does it require
> CONFIG_PM=y?
> If this condition is mandatory and the requirement is valid, Kconfig
> should be changed accordingly.
> I'm not able to verify it works without PM, seems it doesn't.

If CONFIG_PM=n, all pm_runtime_* will do nothing and the imx_thermal core
will stay enabled, see:
 
+/* the core was configured and enabled just before */
+pm_runtime_set_active(&pdev->dev);
+pm_runtime_enable(data->dev);

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |