lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Oct 2021 22:33:54 +0800 From: Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com> To: Marco Elver <elver@...gle.com> CC: Andrey Ryabinin <ryabinin.a.a@...il.com>, Alexander Potapenko <glider@...gle.com>, Andrey Konovalov <andreyknvl@...il.com>, Dmitry Vyukov <dvyukov@...gle.com>, Catalin Marinas <catalin.marinas@....com>, "Will Deacon" <will@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Matthias Brugger <matthias.bgg@...il.com>, Chinwen Chang (張錦文) <chinwen.chang@...iatek.com>, Yee Lee (李建誼) <Yee.Lee@...iatek.com>, Nicholas Tang (鄭秦輝) <nicholas.tang@...iatek.com>, "kasan-dev@...glegroups.com" <kasan-dev@...glegroups.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org> Subject: Re: [PATCH] kasan: add kasan mode messages when kasan init On Tue, 2021-10-19 at 22:14 +0800, Marco Elver wrote: > On Tue, 19 Oct 2021 at 14:04, Kuan-Ying Lee < > Kuan-Ying.Lee@...iatek.com> wrote: > > > > There are multiple kasan modes. It make sense that we add some > > messages > > to know which kasan mode is when booting up. see [1]. > > > > Link: > > https://urldefense.com/v3/__https://bugzilla.kernel.org/show_bug.cgi?id=212195__;!!CTRNKA9wMg0ARbw!374SjX0W47zTqp1xJyIg9CW0T7ggAT1rr981lIRBjQhUk2_495ltG_ZkiW6jmeVDBvu_UA$ > > $ [1] > > Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com> > > Looks good, however, you need to rebase to -next because of "kasan: > Extend KASAN mode kernel parameter"... Thanks Marco. I will send the v2. > > > --- > > arch/arm64/mm/kasan_init.c | 2 +- > > mm/kasan/hw_tags.c | 4 +++- > > mm/kasan/sw_tags.c | 2 +- > > 3 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/mm/kasan_init.c > > b/arch/arm64/mm/kasan_init.c > > index 61b52a92b8b6..b4e78beac285 100644 > > --- a/arch/arm64/mm/kasan_init.c > > +++ b/arch/arm64/mm/kasan_init.c > > @@ -293,7 +293,7 @@ void __init kasan_init(void) > > kasan_init_depth(); > > #if defined(CONFIG_KASAN_GENERIC) > > /* CONFIG_KASAN_SW_TAGS also requires kasan_init_sw_tags(). > > */ > > - pr_info("KernelAddressSanitizer initialized\n"); > > + pr_info("KernelAddressSanitizer initialized (generic)\n"); > > #endif > > } > > > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > > index 05d1e9460e2e..3e28ecbe1d8f 100644 > > --- a/mm/kasan/hw_tags.c > > +++ b/mm/kasan/hw_tags.c > > @@ -168,7 +168,9 @@ void __init kasan_init_hw_tags(void) > > break; > > } > > > > - pr_info("KernelAddressSanitizer initialized\n"); > > + pr_info("KernelAddressSanitizer initialized (hw-tags, > > mode=%s, stacktrace=%s)\n", > > + kasan_flag_async ? "async" : "sync", > > ... which means this will have a 3rd option "asymm". Thanks for the reminder. > > > + kasan_stack_collection_enabled() ? "on" : "off"); > > } > > > > void kasan_alloc_pages(struct page *page, unsigned int order, > > gfp_t flags) > > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > > index bd3f540feb47..77f13f391b57 100644 > > --- a/mm/kasan/sw_tags.c > > +++ b/mm/kasan/sw_tags.c > > @@ -42,7 +42,7 @@ void __init kasan_init_sw_tags(void) > > for_each_possible_cpu(cpu) > > per_cpu(prng_state, cpu) = (u32)get_cycles(); > > > > - pr_info("KernelAddressSanitizer initialized\n"); > > + pr_info("KernelAddressSanitizer initialized (sw-tags)\n"); > > } > > > > /* > > -- > > 2.18.0 > >
Powered by blists - more mailing lists