linux-kernel - Re: [PATCH] NFSD:fix boolreturn.cocci warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211019143708.GB15063@fieldses.org>
Date:   Tue, 19 Oct 2021 10:37:08 -0400
From:   Bruce Fields <bfields@...ldses.org>
To:     Chuck Lever III <chuck.lever@...cle.com>
Cc:     "cgel.zte@...il.com" <cgel.zte@...il.com>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Changcheng Deng <deng.changcheng@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] NFSD:fix boolreturn.cocci warning

On Tue, Oct 19, 2021 at 02:33:36PM +0000, Chuck Lever III wrote:
> 
> 
> > On Oct 19, 2021, at 12:14 AM, cgel.zte@...il.com wrote:
> > 
> > From: Changcheng Deng <deng.changcheng@....com.cn>
> > 
> > ./fs/nfsd/nfssvc.c: 1072: 8-9: :WARNING return of 0/1 in function
> > 'nfssvc_decode_voidarg' with return type bool
> > 
> > Return statements in functions returning bool should use true/false
> > instead of 1/0.
> > 
> > Reported-by: Zeal Robot <zealci@....com.cn>
> > Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
> 
> LGTM.

OK, applying for 5.16.--b.

> 
> 
> > ---
> > fs/nfsd/nfssvc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> > index 362e819ff06a..80431921e5d7 100644
> > --- a/fs/nfsd/nfssvc.c
> > +++ b/fs/nfsd/nfssvc.c
> > @@ -1069,7 +1069,7 @@ int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp)
> >  */
> > bool nfssvc_decode_voidarg(struct svc_rqst *rqstp, struct xdr_stream *xdr)
> > {
> > -	return 1;
> > +	return true;
> > }
> > 
> > /**
> > -- 
> > 2.25.1
> > 
> 
> --
> Chuck Lever
> 
>