linux-kernel - Re: [PATCH v2 1/2] mm/damon: Remove unnecessary variable initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Oct 2021 15:13:38 +0000
From:   SeongJae Park <sj@...nel.org>
To:     Xin Hao <xhao@...ux.alibaba.com>
Cc:     sjpark@...zon.de, akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mm/damon: Remove unnecessary variable initialization

On Tue, 19 Oct 2021 22:26:03 +0800 Xin Hao <xhao@...ux.alibaba.com> wrote:

> In 'damon_va_apply_three_regions', There is no
> need to set variable 'i' as 0
> 
> Signed-off-by: Xin Hao <xhao@...ux.alibaba.com>

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

> ---
>  mm/damon/vaddr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> index b8ba44f69db6..90be463efff7 100644
> --- a/mm/damon/vaddr.c
> +++ b/mm/damon/vaddr.c
> @@ -305,7 +305,7 @@ static void damon_va_apply_three_regions(struct damon_target *t,
>  		struct damon_addr_range bregions[3])
>  {
>  	struct damon_region *r, *next;
> -	unsigned int i = 0;
> +	unsigned int i;
>  
>  	/* Remove regions which are not in the three big regions now */
>  	damon_for_each_region_safe(r, next, t) {
> -- 
> 2.31.0