linux-kernel - Re: [PATCH v2 1/5] tracing: Add support for creating hist trigger variables from literal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211020115908.63022a05@gandalf.local.home>
Date:   Wed, 20 Oct 2021 11:59:07 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Kalesh Singh <kaleshsingh@...gle.com>
Cc:     Suren Baghdasaryan <surenb@...gle.com>,
        Hridya Valsaraju <hridya@...gle.com>,
        Namhyung Kim <namhyung@...nel.org>,
        "Cc: Android Kernel" <kernel-team@...roid.com>,
        Jonathan Corbet <corbet@....net>,
        Ingo Molnar <mingo@...hat.com>, Shuah Khan <shuah@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Tom Zanussi <zanussi@...nel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v2 1/5] tracing: Add support for creating hist trigger
 variables from literal

On Wed, 20 Oct 2021 08:55:23 -0700
Kalesh Singh <kaleshsingh@...gle.com> wrote:

> > BTW, why is there a limit to the number of constants?  
> 
> The motivation was to limit the number of hist_fields that can be
> created for constants. These are also indirectly limited by the max
> number of subexpressions (3) and the max number of vars/keys that can
> be defined, so I don't feel strongly about keeping it.

Yeah. I see the limiting factor is the number of expressions and such. And
as described in my other email, if you have two constants for a single
operand, you can easily combine them into one.

-- Steve