linux-kernel - Re: [PATCH] MIPS: Fix assembly error from MIPSr2 code used within MIPS_ISA_ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 12:20:05 +0200 (CEST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] MIPS: Fix assembly error from MIPSr2 code used within
 MIPS_ISA_ARCH_LEVEL

On Thu, 21 Oct 2021, Maciej W. Rozycki wrote:

> The assembly architecture override is only there for the LLD/SCD 
> instructions, so fix the problem by wrapping these instructions on their 
> own only, following the practice established with commit cfd54de3b0e4 
> ("MIPS: Avoid move psuedo-instruction whilst using MIPS_ISA_LEVEL") and 
> commit 378ed6f0e3c5 ("MIPS: Avoid using .set mips0 to restore ISA").

 Scrap it!  There's so much accumulated cruft around the handling of LL/SC 
sequences that I forgot what the original intent was.  The whole sequence 
has to be assembled for an explicit 64-bit ISA of course as it's meant to 
work with 32-bit kernels.  The commits referred above are red herrings, 
and should not have been needed in the first place if not for the cruft.

 I don't think I'll get to cleaning up the cruft anytime soon, but I'll 
post v2 tonight to address this specific issue.  Long-term perhaps we can 
make some extraneous hacks (ones to address issues with earlier hacks) go 
away.

  Maciej