linux-kernel - Re: [PATCH v2 0/2] perf jevents: Enable build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0B2C61AB-3F0D-4618-B0AD-7143C44B4A3A@gmail.com>
Date:   Thu, 21 Oct 2021 11:36:03 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     John Garry <john.garry@...wei.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     peterz@...radead.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, mingo@...hat.com, irogers@...gle.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        kjain@...ux.ibm.com, james.clark@....com
Subject: Re: [PATCH v2 0/2] perf jevents: Enable build warnings



On October 21, 2021 10:02:41 AM GMT-03:00, John Garry <john.garry@...wei.com> wrote:
>On 21/10/2021 13:55, Arnaldo Carvalho de Melo wrote:
>> Em Thu, Oct 21, 2021 at 05:16:43PM +0800, John Garry escreveu:
>>> Currently jevents builds without any complier warning flags enabled. So
>>> use newly-defined HOSTCFLAGS, which comes from EXTRA_WARNINGS.
>>>
>>> Changes for v2:
>>> - Add Werror, Wall, and Wextra (James Clark suggestion)
>> 
>> Thanks, applied.
>> 
>
>Hi Arnaldo,
>
>Can you please wait until I check the review response from jirka?

Sure, it's not published, and will not be until some fixes are made. Having it in my local tree gets it tested together with the whole shebang in lots of containers.

I collect reviewed-by, etc as they appear.

- Arnaldo

>> 
>>   
>>> Baseline is acme perf/core + mainline commit b94729919db2 ("perf jevents:
>>> Free the sys_event_tables list after processing entries"):
>>>
>>> 680453e63302 perf jevents: Free the sys_event_tables list after processing entries
>>> be8ecc57f180 (origin/perf/core) perf srcline: Use long-running addr2line per DSO
>>> 2b775152bbe8 perf tests vmlinux-kallsyms: Ignore hidden symbols
>>>
>>> John Garry (2):
>>>    perf jevents: Fix some would-be warnings
>>>    perf jevents: Enable warnings through HOSTCFLAGS
>>>
>>>   tools/perf/Makefile.config      |  5 +++++
>>>   tools/perf/Makefile.perf        |  2 +-
>>>   tools/perf/pmu-events/Build     |  2 +-
>>>   tools/perf/pmu-events/jevents.c | 10 ++++------
>>>   4 files changed, 11 insertions(+), 8 deletions(-)
>>>
>>> -- 
>>> 2.17.1
>> 
>