lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 21 Oct 2021 17:20:18 +0200
From:   Paolo Bonzini <>
To:     Michael Roth <>,
        Mingwei Zhang <>
Cc:, kvm <>,
        LKML <>,,
        Nathan Tempelman <>,
        Marc Orr <>,
        Steve Rutherford <>,
        Sean Christopherson <>,
        Brijesh Singh <>,
        Tom Lendacky <>,
        Varad Gautam <>,
        Shuah Khan <>,
        Vitaly Kuznetsov <>,
        David Woodhouse <>,
        Ricardo Koller <>,
        Jim Mattson <>,
        Wanpeng Li <>,
        Joerg Roedel <>,
        Thomas Gleixner <>,
        Ingo Molnar <>, Borislav Petkov <>,
        "H . Peter Anvin" <>
Subject: Re: [RFC 01/16] KVM: selftests: move vm_phy_pages_alloc() earlier in

On 21/10/21 05:45, Michael Roth wrote:
>> Why move the function implementation? Maybe just adding a declaration
>> at the top of kvm_util.c should suffice.
> At least from working on other projects I'd gotten the impression that
> forward function declarations should be avoided if they can be solved by
> moving the function above the caller. Certainly don't mind taking your
> suggestion and dropping this patch if that's not the case here though.

I don't mind moving the code, so the patch is fine.


Powered by blists - more mailing lists