linux-kernel - Re: [PATCH v1] PCI: qcom: Fix incorrect register offset in pcie init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 20:51:44 +0530
From:   Prasad Malisetty <pmaliset@...eaurora.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     svarbanov@...sol.com, agross@...nel.org,
        bjorn.andersson@...aro.org, lorenzo.pieralisi@....com,
        linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, vbadigan@...eaurora.org,
        kw@...ux.com, bhelgaas@...gle.com
Subject: Re: [PATCH v1] PCI: qcom: Fix incorrect register offset in pcie init

On 2021-10-21 13:06, Manivannan Sadhasivam wrote:
> On Fri, Oct 15, 2021 at 12:28:49AM +0530, Prasad Malisetty wrote:
>> In pcie_init_2_7_0 one of the register writes using incorrect offset
>> as per the platform register definitions 
>> (PCIE_PARF_AXI_MSTR_WR_ADDR_HALT
>> offset value should be 0x1A8 instead 0x178).
>> Update the correct offset value for SDM845 platform.
>> 
>> fixes: ed8cc3b1 ("PCI: qcom: Add support for SDM845 PCIe controller")
>> 
>> Signed-off-by: Prasad Malisetty <pmaliset@...eaurora.org>
> 
> After incorporating the reviews from Bjorn H,
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> Thanks,
> Mani
> 

Thanks Mani for the review. I will incorporate the changes as suggested 
by Bjorn H in next patch version.

-Prasad
>> ---
>>  drivers/pci/controller/dwc/pcie-qcom.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c 
>> b/drivers/pci/controller/dwc/pcie-qcom.c
>> index 8a7a300..5bce152 100644
>> --- a/drivers/pci/controller/dwc/pcie-qcom.c
>> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
>> @@ -1230,9 +1230,9 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie 
>> *pcie)
>>  	writel(val, pcie->parf + PCIE20_PARF_MHI_CLOCK_RESET_CTRL);
>> 
>>  	if (IS_ENABLED(CONFIG_PCI_MSI)) {
>> -		val = readl(pcie->parf + PCIE20_PARF_AXI_MSTR_WR_ADDR_HALT);
>> +		val = readl(pcie->parf + PCIE20_PARF_AXI_MSTR_WR_ADDR_HALT_V2);
>>  		val |= BIT(31);
>> -		writel(val, pcie->parf + PCIE20_PARF_AXI_MSTR_WR_ADDR_HALT);
>> +		writel(val, pcie->parf + PCIE20_PARF_AXI_MSTR_WR_ADDR_HALT_V2);
>>  	}
>> 
>>  	return 0;
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project
>>