lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Oct 2021 17:39:34 +0200 From: Paolo Bonzini <pbonzini@...hat.com> To: Michael Roth <michael.roth@....com>, linux-kselftest@...r.kernel.org Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org, Nathan Tempelman <natet@...gle.com>, Marc Orr <marcorr@...gle.com>, Steve Rutherford <srutherford@...gle.com>, Sean Christopherson <seanjc@...gle.com>, Mingwei Zhang <mizhang@...gle.com>, Brijesh Singh <brijesh.singh@....com>, Tom Lendacky <thomas.lendacky@....com>, Varad Gautam <varad.gautam@...e.com>, Shuah Khan <shuah@...nel.org>, Vitaly Kuznetsov <vkuznets@...hat.com>, David Woodhouse <dwmw@...zon.co.uk>, Ricardo Koller <ricarkol@...gle.com>, Jim Mattson <jmattson@...gle.com>, Wanpeng Li <wanpengli@...cent.com>, Joerg Roedel <joro@...tes.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, "H . Peter Anvin" <hpa@...or.com> Subject: Re: [RFC 06/16] KVM: selftests: add library for creating/interacting with SEV guests On 06/10/21 22:37, Michael Roth wrote: > +struct sev_sync_data { > + uint32_t token; > + bool pending; > + bool done; > + bool aborted; > + uint64_t info; > +}; > + Please add a comment explaining roughly the design and what the fields are for. Maybe the bools can be replaced by an enum { DONE, ABORT, SYNC, RUNNING } (running is for pending==false)? Also, for the part that you can feel free to ignore: this seems to be similar to the ucall mechanism. Is it possible to implement the ucall interface in terms of this one (or vice versa)? One idea could be to: - move ucall to the main lib/ directory - make it use a struct of function pointers, whose default implementation would be in the existing lib/ARCH/ucall.c files - add a function to register the struct for the desired implementation - make sev.c register its own implementation Thanks, Paolo
Powered by blists - more mailing lists