[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YXJ6deXN7vWrSc++@ninjato>
Date: Fri, 22 Oct 2021 10:46:45 +0200
From: Wolfram Sang <wsa@...nel.org>
To: Dmitry Osipenko <digetx@...il.com>
Cc: Lee Jones <lee.jones@...aro.org>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Laxman Dewangan <ldewangan@...dia.com>,
linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
linux-i2c@...r.kernel.org
Subject: Re: [PATCH v1 3/3] mfd: tps80031: Remove driver
> It's I2C driver. I'm not sure about auto-probing because something
> should provide information about device to Linux. It's possible to
> detect/scan whether there is device sitting on I2C address, but there is
> no auto-discovery mechanism, AFAIK.
Well, in general, it could be manually instantiated from userspace...
>
> TPS80031 device will fail to bind to this driver because it explicitly
> requires platform data which should be NULL if device is probed solely
> by I2C ID.
..but I agree in this case. The driver has this code:
if (!pdata) {
dev_err(&client->dev, "tps80031 requires platform data\n");
return -EINVAL;
}
and git grep shows no user having platform data.
Shouldn't 'drivers/regulator/tps80031-regulator.c' and
'./rtc/rtc-tps80031.c' be removed as well?
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists