linux-kernel - Re: [Outreachy kernel] [PATCH 5/5] staging: vt6655: Rename `byRFType` variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <049d4b3e-ed32-9b48-0c2e-19f9af95ca37@gmail.com>
Date:   Fri, 22 Oct 2021 19:56:30 +0530
From:   Praveen Kumar <kpraveen.lkml@...il.com>
To:     Karolina Drobnik <karolinadrobnik@...il.com>,
        outreachy-kernel@...glegroups.com
Cc:     gregkh@...uxfoundation.org, forest@...ttletooquiet.net,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH 5/5] staging: vt6655: Rename `byRFType`
 variable

On 22-10-2021 15:07, Karolina Drobnik wrote:
> Drop Hungarian notation in `byRFType` variable in
> `RFvWriteWakeProgSyn` function. Change it to use snake case.
> 
> Fix issue detected by checkpatch.pl:
>   CHECK: Avoid CamelCase: <byRFType>
> 
> Signed-off-by: Karolina Drobnik <karolinadrobnik@...il.com>
> ---
>  drivers/staging/vt6655/rf.c | 4 ++--
>  drivers/staging/vt6655/rf.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> index 0dd91b0433f6..3f57834901a6 100644
> --- a/drivers/staging/vt6655/rf.c
> +++ b/drivers/staging/vt6655/rf.c
> @@ -676,7 +676,7 @@ bool RFbSelectChannel(struct vnt_private *priv, unsigned char byRFType,
>   * Return Value: None.
>   *
>   */
> -bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
> +bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char rf_type,
>  			 u16 channel)
>  {
>  	void __iomem *iobase = priv->port_offset;
> @@ -685,7 +685,7 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
>  	unsigned char sleep_count = 0;
>  
>  	VNSvOutPortW(iobase + MAC_REG_MISCFFNDEX, 0);
> -	switch (byRFType) {
> +	switch (rf_type) {
>  	case RF_AIROHA:
>  	case RF_AL2230S:
>  
> diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
> index d3f2b8dd6afc..0939937d47a8 100644
> --- a/drivers/staging/vt6655/rf.h
> +++ b/drivers/staging/vt6655/rf.h
> @@ -60,7 +60,7 @@
>  bool IFRFbWriteEmbedded(struct vnt_private *priv, unsigned long dwData);
>  bool RFbSelectChannel(struct vnt_private *priv, unsigned char byRFType, u16 byChannel);

IMO, probably we can sync RFbSelectChannel as well with similar notation in another patch.

>  bool RFbInit(struct vnt_private *priv);
> -bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType, u16 channel);
> +bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char rf_type, u16 channel);
>  bool RFbSetPower(struct vnt_private *priv, unsigned int rate, u16 uCH);
>  bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
>  		    unsigned int rate);
> 

Regards,

~Praveen.