linux-kernel - Re: [PATCH] scsi: ufs: clean up the Kconfig file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8578e393-2a25-bc52-65ea-599d071387e9@acm.org>
Date:   Sun, 24 Oct 2021 14:29:21 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>, linux-scsi@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH] scsi: ufs: clean up the Kconfig file

On 10/23/21 23:43, Randy Dunlap wrote:
> @@ -39,7 +38,7 @@ config SCSI_UFSHCD
>   	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>   	select NLS
>   	help
> -	  This selects the support for UFS devices in Linux, say Y and make
> +	  This selects the support for UFS devices in Linux. Say Y and make

How about changing "This selects the support for UFS devices in Linux"
into "Enables support for UFS devices"? "the" should be left out from a
grammatical point of view and "in Linux" is redundant.

>   	  sure that you know the name of your UFS host adapter (the card
>   	  inside your computer that "speaks" the UFS protocol, also
>   	  called UFS Host Controller), because you will be asked for it.
> @@ -51,7 +50,7 @@ config SCSI_UFSHCD
>   	  (the one containing the directory /) is located on a UFS device.
>   
>   config SCSI_UFSHCD_PCI
> -	tristate "PCI bus based UFS Controller support"
> +	tristate "PCI bus-based UFS Controller support"

Even with this change applied capitalization is inconsistent.

Thanks,

Bart.