linux-kernel - Re: [PATCH v2 4/8] staging: vchiq_core.h: use preferred kernel types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Oct 2021 09:11:20 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Gaston Gonzalez <gascoar@...il.com>
Cc:     linux-staging@...ts.linux.dev, nsaenz@...nel.org,
        stefan.wahren@...e.com, arnd@...db.de, dan.carpenter@...cle.com,
        ojaswin98@...il.com, amarjargal16@...il.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/8] staging: vchiq_core.h: use preferred kernel types

On Sun, Oct 24, 2021 at 06:25:20PM -0300, Gaston Gonzalez wrote:
> Change types from uint32_t and uint64_t to the preferred ones u32 and
> u64.
> 
> Reported by checkpatch.pl, with the exception of the one in function
> vchiq_log_dump_mem().
> 
> Signed-off-by: Gaston Gonzalez <gascoar@...il.com>
> ---
>  .../vc04_services/interface/vchiq_arm/vchiq_core.h   | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> index 383c3bcf787e..a107c72ce3a6 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> @@ -74,7 +74,7 @@
>  	((fourcc) >>  8) & 0xff, \
>  	(fourcc) & 0xff
>  
> -typedef uint32_t BITSET_T;
> +typedef u32 BITSET_T;

This is fine for now, but you should also work to get rid of this
unneeded typedef entirely.

thanks,

greg k-h