linux-kernel - Re: [PATCH] bpf: Move BPF_MAP_TYPE for INODE_STORAGE and TASK_STORAGE outside of CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211026192530.jogbgykrgra5ic4v@kafai-mbp.dhcp.thefacebook.com>
Date:   Tue, 26 Oct 2021 12:25:30 -0700
From:   Martin KaFai Lau <kafai@...com>
To:     Tejun Heo <tj@...nel.org>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>, <kernel-team@...com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpf: Move BPF_MAP_TYPE for INODE_STORAGE and
 TASK_STORAGE outside of CONFIG_NET

On Tue, Oct 26, 2021 at 12:19:36PM -0700, Martin KaFai Lau wrote:
> On Thu, Oct 21, 2021 at 08:46:10AM -1000, Tejun Heo wrote:
> > bpf_types.h has BPF_MAP_TYPE_INODE_STORAGE and BPF_MAP_TYPE_TASK_STORAGE
> > declared inside #ifdef CONFIG_NET although they are built regardless of
> > CONFIG_NET. So, when CONFIG_BPF_SYSCALL && !CONFIG_NET, they are built
> > without the declarations leading to spurious build failures and not
> > registered to bpf_map_types making them unavailable.
> > 
> > Fix it by moving the BPF_MAP_TYPE for the two map types outside of
> > CONFIG_NET.
> Acked-by: Martin KaFai Lau <kafai@...com>

btw, this should be the fix tag that has both task and inode storage.
Fixes: a10787e6d58c ("bpf: Enable task local storage for tracing programs")