linux-kernel - Re: [PATCH v2] ubifs: ubifs to export filesystem error counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2065858791.38760.1635277003599.JavaMail.zimbra@nod.at>
Date:   Tue, 26 Oct 2021 21:36:43 +0200 (CEST)
From:   Richard Weinberger <richard@....at>
To:     schaecsn <schaecsn@....net>
Cc:     linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Stefan Schaeckeler <sschaeck@...co.com>
Subject: Re: [PATCH v2] ubifs: ubifs to export filesystem error counters

Stefan,

----- Ursprüngliche Mail -----
> Von: "schaecsn" <schaecsn@....net>
> An: "richard" <richard@....at>, "linux-mtd" <linux-mtd@...ts.infradead.org>, "linux-kernel"
> <linux-kernel@...r.kernel.org>
> CC: "schaecsn" <schaecsn@....net>, "Stefan Schaeckeler" <sschaeck@...co.com>
> Gesendet: Sonntag, 10. Oktober 2021 06:22:39
> Betreff: [PATCH v2] ubifs: ubifs to export filesystem error counters

> Not all ubifs filesystem errors are propagated to userspace.
> 
> Export bad magic, bad node and crc errors via sysfs. This allows userspace
> to notice filesystem errors:
> 
> /sys/fs/ubifs/ubiX_Y/errors_magic
> /sys/fs/ubifs/ubiX_Y/errors_node
> /sys/fs/ubifs/ubiX_Y/errors_crc
> 
> The counters are reset to 0 with a remount.
> 
> Signed-off-by: Stefan Schaeckeler <sschaeck@...co.com>
> ---
> Changes in v2:
>  - merged sysfs.h header into ubifs.h.
>  - io.c: wrapped incrementing error counters into new functions
>    record_*_error().
>  - sysfs.c: removed sysfs write callback for clearing stats.
>  - sysfs.c: ubifs_sysfs_register(): free c->stats on error.
>  - sysfs.c: ubifs_attr_show(): use sysfs_emit().
> 
> fs/ubifs/Makefile |   2 +-
> fs/ubifs/io.c     |  21 +++++++
> fs/ubifs/super.c  |  16 ++++-
> fs/ubifs/sysfs.c  | 153 ++++++++++++++++++++++++++++++++++++++++++++++
> fs/ubifs/ubifs.h  |  35 +++++++++++
> 5 files changed, 225 insertions(+), 2 deletions(-)
> create mode 100644 fs/ubifs/sysfs.c

Queued for 5.16.

I just noticed forgot to request sysfs documentation in Documentation/ABI/.
Can you please send a followup patch?

Thanks,
//richard